Repository navigation
test: kill escaped mutants - #142
Merged
Merged
Conversation
Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
The ignored mutants have no observable effect: a skipped relation property is always followed by more skipped ones, an explicit column name wins inside initField anyway, an empty column or index list is a no-op, the STI children map already holds class names, and an STI parent shares its table and primary key with the root. Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.x #142 +/- ##
==========================================
+ Coverage 87.28% 91.86% +4.57%
==========================================
Files 39 39
Lines 873 848 -25
==========================================
+ Hits 762 779 +17
+ Misses 111 69 -42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Configurator(typecast and name resolution, embeddings, column options, relation inverse and collection, foreign keys, reader errors),Entitiesname resolution,MergeColumns/MergeIndexescopying from mapper, repository, source, scope, parents and children, and table inheritance.infection.json:Continue_inConfigurator::initRelations()(properties of a parent entity always come last, sobreakskips the same ones),CoalesceinConfigurator::initColumns()(initField()prefers the explicit column name anyway),ReturnRemovalinMergeColumns::copy()andMergeIndexes::render()(an empty list is a no-op),UnwrapArrayMapinTableInheritance(the STI children map already holds class names),ReturnRemoval/FalseValueinTableInheritance::getParentForForeignKey()(an STI parent shares the root's table and primary key).Why?
Mutation score on Linux: 83.3% → 98.81%, escaped mutants 85 → 6.
Review notes
The 6 mutants left in
TableInheritancepoint at two bugs, left for separate fixes:getTableName()andgetDatabase()look at the immediate parent, not the STI root. A second-level STI child (Ceo→Employee→PersoninFixtures16) is linked to its own table, andSyncTablescreates an emptyceostable. Mutants at lines 306 and 325.Square#[SingleTable]→Polygon#[JoinedTable]→Shape) is merged into the rootshapestable instead ofpolygons, andremoveStiExtraFields()then dropsPolygon's columns from it. The mutants at lines 91, 154, 218 and 220 are only observable in this case, so no test pins it.Checklist