Repository navigation
test: raise line coverage - #147
Merged
Merged
Conversation
roxblnfk
force-pushed
the
test/coverage-100
branch
from
November 20, 2026 20:36
bd30573 to
5bafe4b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.x #147 +/- ##
==========================================
+ Coverage 92.68% 99.39% +6.71%
==========================================
Files 39 39
Lines 847 824 -23
==========================================
+ Hits 785 819 +34
+ Misses 62 5 -57
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The Unit coverage run never loaded these attribute classes, so Codecov kept counting their constructor lines from static analysis as missed. Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
… failure paths Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
TableInheritance, MergeColumns and MergeIndexes ran only in the SQLite suite, so the Unit coverage report counted their lines from static analysis, including assert() and multi-line arguments that pcov never reports, and Codecov kept them missed. Assisted-By: Claude Opus 5.5 <noreply@anthropic.com>
roxblnfk
force-pushed
the
test/coverage-100
branch
from
November 20, 2026 20:51
5bafe4b to
7a15568
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Configurator, the reader failures ofEmbeddings,MergeColumns,MergeIndexesandTableInheritance, a missing related class in the two merge generators,TableInheritancewith a big primary key, a wrong outer key, a custom inheritance type, an unregistered parent and an orphan STI field, a foreign key without an outer key, and an enum column whose values come from an enum case.Why?
The target is 100% line coverage on Codecov.
Review notes
function __construct(line,assert()calls and the inner lines of multi-line calls, which pcov never reports for a loaded file. Codecov merges the flags, so these lines stayed missed although SQLite ran them. Running the class in the Unit suite too replaces those lines with pcov's own. The object has to be built inside the test: a data provider runs outside the coverage window, so a constructor called there still counts as missed.Configurator::initColumns()throws "Column name definition is required" only with assertions disabled: the\assert(!empty($propertyName))right above it fails first for the same input.!$currentClass instanceof \ReflectionClassexit ofConfigurator::findOwningEntity()(a property's declaring class is always in its class's hierarchy) and theReflectionExceptioncatch inEntityUtils::findParents()(class_parents()lists only loaded classes).Checklist