Skip to content

Fix keys processing in BulkLoader#558

Merged
roxblnfk merged 3 commits into2.xfrom
fix-bulk-loader-stringable-keys
Mar 6, 2026
Merged

Fix keys processing in BulkLoader#558
roxblnfk merged 3 commits into2.xfrom
fix-bulk-loader-stringable-keys

Conversation

@roxblnfk
Copy link
Member

@roxblnfk roxblnfk commented Mar 6, 2026

🔍 What was changed

Now all the necessary keys (PK, FK) will be converted to scalar in same way. It respects DB's ValueInterface and Stringable

🤔 Why?

To use object IDs

📝 Checklist

  • How was this tested:
    • Tested manually
    • Unit tests added

@roxblnfk roxblnfk added this to the 2.14.x milestone Mar 6, 2026
@roxblnfk roxblnfk merged commit 2e9463e into 2.x Mar 6, 2026
26 of 28 checks passed
@roxblnfk roxblnfk deleted the fix-bulk-loader-stringable-keys branch March 6, 2026 06:58
@codecov
Copy link

codecov bot commented Mar 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.82%. Comparing base (c6d621b) to head (8f9d9d4).
⚠️ Report is 1 commits behind head on 2.x.

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x     #558      +/-   ##
============================================
+ Coverage     91.80%   91.82%   +0.02%     
+ Complexity     1966     1963       -3     
============================================
  Files           131      131              
  Lines          5039     5054      +15     
============================================
+ Hits           4626     4641      +15     
  Misses          413      413              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant