Repository navigation
Fix mcu_dsi_regs.mem reading, add multibyte 3DS MCU register files - #984
Open
ZeroSkill1 wants to merge 1 commit into
Open
ZeroSkill1 wants to merge 1 commit into
ZeroSkill1 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The I2C slave controller used for BPTWL emulation delibterately does not support multi-byte reading. Therefore, reading more than one byte from
mcu_dsi_regs.memwould return allFFbytes past the first one. The fix (same as #982) involves reading each register byte-by-byte.In addition, all available multi-byte registers on the 3DS-side of the MCU I2C device are added as additional virtual files in
[M:] MEMORY VIRTUAL:mcu_3ds_info.memmcu_3ds_step_history.memmcu_3ds_storage_area.mem