Skip to content

chore: optimize AI agent configuration - #24

Merged
jpoley merged 3 commits into
mainfrom
chore/agentic-setup
May 23, 2026
Merged

jpoley merged 3 commits into
mainfrom
chore/agentic-setup

Conversation

@jpoley

@jpoley jpoley commented May 23, 2026

Copy link
Copy Markdown
Contributor

Addressed Copilot feedback from #23 (5 comments):

  • Aligned the skill-validation copy command with CI by adding || true after cp -r ./* ./.* /tmp/vagrant/ 2>/dev/null so it is copy/paste-safe under set -e. Fixed in .claude/workflow.md, .claude/stack.md, .claude/language.md, and both occurrences in .github/copilot-instructions.md.
  • Reworded the Definition-of-Done [FILL IN] bullet in .github/copilot-instructions.md to "no unresolved placeholders," resolving the contradiction with the intentional literal [FILL IN] marker definitions in .claude/stack.md and .claude/language.md.

All 5 comments addressed; none skipped.

Validation: producer Claude Opus 4.7 / self-review (verdict: pass — cross-provider not available this round).

jpoley and others added 3 commits May 23, 2026 08:29
Install the full agent-config file set (CLAUDE.md, AGENTS.md,
copilot-instructions.md, and .claude/*.md) tailored to this skill
package: Ruby Vagrantfile + Bash scripts, bats-core tests, the Agent
Skills standard, and the make lint/test workflow. Folds the existing
skill-specific CLAUDE.md guidance into the template structure.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Align documented skill-validation copy command with CI (add `|| true`
after cp so it is safe under set -e) across .claude/workflow.md,
.claude/stack.md, .claude/language.md, and .github/copilot-instructions.md.
Reword the DoD FILL IN bullet so the intentional marker definitions in
.claude/stack.md and .claude/language.md no longer violate it.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings May 23, 2026 09:30

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repository’s AI-agent entry points and guidance docs to better align with the existing CI validation workflow and to remove contradictory “Definition of Done” wording, improving copy/paste safety under set -e and clarifying placeholder expectations.

Changes:

  • Aligns documented skill-validation command with CI by making the cp step set -e-safe (|| true) across agent instruction docs.
  • Adds/standardizes multi-agent guidance files (AGENTS.md, .github/copilot-instructions.md, .claude/*.md) and refreshes CLAUDE.md structure/content.
  • Clarifies Definition-of-Done language around [FILL IN] placeholders to avoid contradicting the “literal marker” convention docs.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
CLAUDE.md Reworks the Claude entry point with clearer project/guardrail sections and adds an include reference to .claude/workflow.md.
AGENTS.md Adds a Codex-compatible agent entry point mirroring core project/guardrail guidance.
.github/copilot-instructions.md Adds GitHub Copilot-specific repository instructions, including CI-aligned skill validation command and DoD wording.
.claude/workflow.md Adds workflow rules and Definition-of-Done including the CI-aligned validation copy command.
.claude/stack.md Documents stack facts and the CI validation workaround; defines [FILL IN] marker semantics.
.claude/sourcecontrol.md Adds source-control conventions for branches, commits, PRs, releases, and destructive operations.
.claude/language.md Documents language/tooling conventions and references the CI validation workaround.
.claude/history.md Defines JSONL formats and rules for decision/reference logging under .logs/.
.claude/architecture.md Adds architecture guidance tailored to a “skill package” repo and references decision logging.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jpoley
jpoley merged commit 353cd3a into main May 23, 2026
10 checks passed
@jpoley
jpoley deleted the chore/agentic-setup branch May 23, 2026 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants