Skip to content

Conversation

@kabilar
Copy link
Member

@kabilar kabilar commented Jan 29, 2026

@kabilar kabilar requested a review from yarikoptic January 29, 2026 22:17
@kabilar kabilar self-assigned this Jan 29, 2026
@kabilar kabilar added zarr patch Increment the patch version when merged release Create a release when this pr is merged labels Jan 29, 2026
@codecov
Copy link

codecov bot commented Jan 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.08%. Comparing base (ccdb659) to head (5b1c6a9).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1779      +/-   ##
==========================================
- Coverage   75.11%   75.08%   -0.03%     
==========================================
  Files          84       84              
  Lines       11921    11921              
==========================================
- Hits         8954     8951       -3     
- Misses       2967     2970       +3     
Flag Coverage Δ
unittests 75.08% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yarikoptic
Copy link
Member

let's see if

fixes CI, and then that there is no side-effect here and hopefully merge/release tomorrow

@yarikoptic
Copy link
Member

there is a concoction of fails which emerged recently (after 18th), trying to figure it out (well - claude does ;) ), here is related here

Potential New Issue: Zarr 3.1.x Compatibility

I discovered that zarr 3.1.0+ has breaking changes that could be causing the failures you're seeing:

Key Breaking Changes in Zarr 3.1.0:

  1. NumPy minimum version increased to 1.26 (https://zarr.readthedocs.io/en/v3.1.0/release-notes.html)
  2. Data type system refactor
  3. Regressions with inf/-inf/nan values in attributes (fixed in 3.1.1)
  4. Group creation errors in 3.1.2
  5. Removed ability to pass kwargs positionally to many functions

so might want to blacklist 3.1.1 as part of this PR, but let's wait if I figure more of other issues etc

@yarikoptic
Copy link
Member

actually -- here we have only macos and only intel failing on unrelated tests -- let's just proceed with this

@yarikoptic yarikoptic merged commit 90e0054 into dandi:master Jan 30, 2026
32 of 39 checks passed
@github-actions
Copy link

🚀 PR was released in 0.74.2 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch Increment the patch version when merged release Create a release when this pr is merged released zarr

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants