refs #14304/#14242 - fixed active checkers with UNUSEDFUNCTION_ONLY hack
#8005
+99
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firewave
changed the title
UNUSEDFUNCTION_ONLY hackUNUSEDFUNCTION_ONLY hack
Collaborator
Author
|
Although it looks like this only caters towards the hack it actually advances towards making this an actual feature. It is also the very first step in trying to get a hold of the differing/misleading checker data being shown. There are several more issues which need to be tackled incrementally and I already have tests which do not utilize the hack and highlight these. This also seems to have uncovered some messiness in the way the unused function check and the whole program analysis are being invoked. |
firewave
force-pushed
the
unusedf-hack-xxx
branch
from
7097876 to
608336f
Compare
firewave
commented
Dec 4, 2025
Comment on lines
+70
to
71
| // TODO: CppCheckExecutor::check_internal() is also invoking the whole program analysis - is it run twice? | ||
| if (mCppcheck.analyseWholeProgram()) |
Collaborator
Author
There was a problem hiding this comment.
This looks like https://trac.cppcheck.net/ticket/13543.
danmar
previously approved these changes
Dec 7, 2025
…NUSEDFUNCTION_ONLY` hack
firewave
force-pushed
the
unusedf-hack-xxx
branch
from
608336f to
aa09401
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.