DAOS-19248 test: Fix no tag match for Functional VM stages - #18597
Conversation
Ensure Functional VM stages are skipped if no test tags match. Test-tag: test_always_passes_hw Skip-functional-on-el-8: false Skip-functional-on-el-9: false Skip-functional-on-leap-15: false Skip-functional-on-sles-15: false Signed-off-by: Phil Henderson <phillip.henderson@hpe.com>
|
Ticket title is 'Update testing branches' |
Skip-test-hardware: true Test-tag: test_load_mpi test_setup_vm Signed-off-by: Phil Henderson <phillip.henderson@hpe.com>
|
Test stage Functional on EL 9 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-18597/5/display/redirect |
|
Test stage Functional on EL 9 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-18597/7/display/redirect |
|
Test stage Functional on EL 8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18597/13/execution/node/1065/log |
Skip-cancel-previous-builds: true Skip-functional-test: true SKip-fault-injection-testing: true Skip-unit-tests: true Signed-off-by: Phil Henderson <phillip.henderson@hpe.com>
skip-unit-tests: true skip-test-hardware: true skip-functional-on-el-8: false skip-functional-on-leap-15: false skip-functional-on-sles-15: false test-tag: test_load_mpi test_setup_vm Signed-off-by: Phil Henderson <phillip.henderson@hpe.com>
|
Test stage Test RPMs on Leap 15.5 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18597/15/execution/node/831/log |
|
Test stage Functional on EL 8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18597/15/execution/node/944/log |
In Build 15 the According to https://daosio.atlassian.net/browse/DAOS-18925, we need |
skip-unit-tests: true skip-test-hardware: true skip-functional-on-el-8: false skip-functional-on-leap-15: false skip-functional-on-sles-15: false test-tag: test_load_mpi test_setup_vm Signed-off-by: Phil Henderson <phillip.henderson@hpe.com>
sjip-cancel-previous-builds: true skip-unit-tests: true skip-test-hardware: true skip-functional-on-el-9: true skip-fault-injection-testing: true Signed-off-by: Phil Henderson <phillip.henderson@hpe.com>
|
Test stage Test RPMs on Leap 15.5 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-18597/17/display/redirect |
skip-unit-tests: true skip-test-hardware: true skip-functional-on-el-9: true skip-fault-injection-testing: true Signed-off-by: Phil Henderson <phillip.henderson@hpe.com>
|
Test stage Test RPMs on Leap 15.5 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-18597/18/display/redirect |
skip-unit-tests: true skip-test-hardware: true skip-functional-on-el-8: false skip-functional-on-leap-15: false skip-functional-on-sles-15: false test-tag: test_load_mpi test_setup_vm Signed-off-by: Phil Henderson <phillip.henderson@hpe.com>
|
Test stage Functional on EL 8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18597/19/execution/node/948/log |
skip-unit-tests: true skip-test-hardware: true skip-functional-on-el-8: false skip-functional-on-leap-15: false skip-functional-on-sles-15: false test-tag: test_load_mpi test_setup_vm Signed-off-by: Phil Henderson <phillip.henderson@hpe.com>
|
Test stage Test RPMs on Leap 15.5 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18597/20/execution/node/973/log |
|
Test stage Functional on EL 8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18597/20/execution/node/1087/log |
This failure is expected until https://daosio.atlassian.net/browse/DAOS-15233 has been resolved. |
|
Note the improved artifacts for the RPM Test RPM stages: |
|
Test stage Functional Cluster Box Medium MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18597/45/execution/node/1511/log |
|
Test stage Functional Hardware Large MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18597/45/execution/node/1608/log |
|
Test stage Functional Hardware Medium MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18597/45/execution/node/1743/log |
|
Test stage Functional Hardware Medium Verbs Provider MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18597/45/execution/node/1792/log |
|
Test stage Functional Cluster Box Medium MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18597/46/execution/node/728/log |
|
Test stage Functional Hardware Large MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18597/46/execution/node/910/log |
|
Test stage Functional Hardware Medium Verbs Provider MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18597/46/execution/node/920/log |
|
Test stage Functional Hardware Medium MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18597/46/execution/node/1007/log |
|
Testing passed in https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-18597/50/stages where:
|
daltonbohning
left a comment
There was a problem hiding this comment.
Is this working? The latest CI seems to still be failing due to "no tests in stage"
| unstashTests: false, | ||
| imageVersion: 'el9.7', | ||
| provEnvVars: 'VM_CPUS=14', | ||
| unitTestArgs: [ |
There was a problem hiding this comment.
Seeing it this way, it seems odd that a function called scriptedUnitTestStage has an argument unitTestArgs because I would assume all args to scriptedUnitTestStage are "unit test" arguments :)
There was a problem hiding this comment.
I can see where you're coming from, but the Unit Test Stage encompasses more than just the unitTest function; it calls:
- the unitTest function
- the unitTestPost function
- the archiveArtifacts function
- the jobStatusUpdate function
so, its arguments are not just arguments exclusive to the unitTest function.
Signed-off-by: Phil Henderson <phillip.henderson@hpe.com>
If we're talking about https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos/job/PR-18597/50/stages, then yes. The build was run with: The
None of the Functional HW stages ran - as expected: 4 stages due to no tags match; 5 stages due to default run parameters (e.g. the runStage argument):
|
Signed-off-by: Phil Henderson <phillip.henderson@hpe.com>
|
Test stage Functional Hardware Medium MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18597/54/execution/node/1702/log |
|
Test stage Functional Cluster Box Medium MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18597/54/execution/node/1518/log |
…18715) Define the stages in the Test stage as scripted stages to enable running the Functional Test stages run on VM with the getFunctionalTestStage() method. This will enable using testsInStage() to verify the test tags will result in at least one test to be run by this stage - fixing a current issue where VM Functional test stages can fail with no tests matching the tags. To run the Test RPM and Fault injection testing stages as scripted stages two new pipeline-lib methods are being utilized: scriptedTestRpmStage() and scriptedUnitTestStage(). Additional fixes/changes: - fix running the Test RPMs on EL 9.6 stage on EL 9.6 instead of 9.7 - rename Test RPMs on EL 9.6 stage to Test RPMs on EL 9 - rename Test RPMs on Leap 15.5 to Test RPMs on Leap 15 - add collecting a log for the Test RPMs stages and log the distro - groovyLint cleanup in the Jenkinsfile Signed-off-by: Phil Henderson <phillip.henderson@hpe.com>
Define the stages in the Test stage as scripted stages to enable running the
Functional Test stages run on VM with the getFunctionalTestStage() method.
This will enable using testsInStage() to verify the test tags will result in at
least one test to be run by this stage - fixing a current issue where VM
Functional test stages can fail with no tests matching the tags. To run the
Test RPM and Fault injection testing stages as scripted stages two new
pipeline-lib methods are being utilized: scriptedTestRpmStage() and
scriptedUnitTestStage().
Additional fixes/changes:
Test-tag: test_always_passes_hw
Skip-functional-on-el-8: false
Skip-functional-on-el-9: false
Skip-functional-on-leap-15: false
Skip-functional-on-sles-15: false
Steps for the author:
After all prior steps are complete: