DAOS-19368 object: make fill_[key|rec] do not return error codes - #18767
Draft
janekmi wants to merge 1 commit into
Draft
DAOS-19368 object: make fill_[key|rec] do not return error codes#18767janekmi wants to merge 1 commit into
janekmi wants to merge 1 commit into
Conversation
Signed-off-by: Jan Michalski <jan-marian.michalski@hpe.com>
|
Ticket title is 'Aurora daos_user: Observed Error message in log "DER_KEY2BIG(-2012): 'Key is too large'" while doing rebuild' |
6 tasks
Collaborator
|
Test stage Functional Cluster Box Medium MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18767/1/execution/node/1713/log |
NiuYawei
reviewed
Aug 4, 2026
| return -DER_KEY2BIG; | ||
| } else { | ||
| return 1; | ||
| arg->rc_key2big = 1; |
Contributor
There was a problem hiding this comment.
This flag should not be set for the original 'else' case.
| D_DEBUG(DB_IO, "enum type %d rc %d\n", type, rc); | ||
| D_DEBUG(DB_IO, "enum type %d rc %d rc_key2big %d\n", type, rc, arg->rc_key2big == 1); | ||
|
|
||
| if (arg->rc_key2big) { |
Contributor
There was a problem hiding this comment.
Clear this flag at the beginning of this function in case the caller retries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steps for the author:
After all prior steps are complete: