DAOS-19397 test: fix int_rebuild_stranded_lower_fseq_target() - #18772
Merged
Conversation
Before this change, the test was not prepared for the case where either of the two ranks (A, B) selected to be killed was acting as the pool service leader. For example if rank_B is the leader when it is killed, a leadership change occurs and the test does not see the single-leader lower rs_version Fail_reclaim it expects, leading to a test hang. With this change, two non-leader engine ranks are chosen to be the ranks A and B that the test kills. The selection of the ranks is still done by inspecting the first object's 3 replica locations, but specifically avoids choosing the leader rank if it happens to store one of the replicas. Test-tag: test_daos_rebuild_interactive Skip-unit-tests: true Skip-fault-injection-test: true Skip-test-rpms: true Signed-off-by: Kenneth Cain <kenneth.cain@hpe.com>
|
Ticket title is 'daos_test/suite.py:DaosCoreTest.test_daos_rebuild_interactive - rebuild for pool has started, rs_version=19 (waiting for < 10) eventually test timeout ' |
kccain
added
the
forced-landing
kccain
marked this pull request as ready for review
August 3, 2026 22:08
daltonbohning
added
the
approved-to-merge
gnailzenh
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change, the test was not prepared for the case where either of the two ranks (A, B) selected to be killed was acting as the pool service leader. For example if rank_B is the leader when it is killed, a leadership change occurs and the test does not see the single-leader lower rs_version Fail_reclaim it expects, leading to a test hang.
With this change, two non-leader engine ranks are chosen to be the ranks A and B that the test kills. The selection of the ranks is still done by inspecting the first object's 3 replica locations, but specifically avoids choosing the leader rank if it happens to store one of the replicas.
Test-tag: test_daos_rebuild_interactive
Skip-unit-tests: true
Skip-fault-injection-test: true
Skip-test-rpms: true
Steps for the author:
After all prior steps are complete: