SRE-3965 tests: Retag cb ftests and refine hw-medium stages - #18810
SRE-3965 tests: Retag cb ftests and refine hw-medium stages#18810ryon-jensen wants to merge 1 commit into
Conversation
|
Errors are Unable to load ticket data |
This change changes the strategy slightly between hw and cb test tags. All cb tests can run on hw stages as well. Filter out cb tags on HW stages where there is clear cb coverage. Signed-off-by: Ryon Jensen <ryon.jensen@hpe.com>
8d60c05 to
dc4ff47
Compare
| label: params.FUNCTIONAL_HARDWARE_MEDIUM_LABEL, | ||
| next_version: next_version(), | ||
| stage_tags: 'hw,medium,-provider', | ||
| stage_tags: 'hw,medium,-provider,-cb', |
There was a problem hiding this comment.
How would someone run a test tagged with both cb and hw in a HW stage?
There was a problem hiding this comment.
They would have to modify a line like this one. If we wanted to be able to control the behavior through commit pragmas, we could make the inclusion of ,-cb optional with something like:
| stage_tags: 'hw,medium,-provider,-cb', | |
| stage_tags: 'hw,medium,-provider' + | |
| (cachedCommitPragma(pragma: 'Func-hw-exclude-cb-tests', def_val: 'true').toLowerCase() == 'true' ? ',-cb' : ''), |
There was a problem hiding this comment.
The reason for this change is we don't have Cluster Box stages in daily/weekly pipelines - including situations where we run the tests with different providers, so to avoid not running those tests they need to support being run in both CB and HW stages.
There was a problem hiding this comment.
Why don't we add Cluster Box stages to daily/weekly? I think having it be different in PRs vs daily/weekly means we might have failures in one but not the other and trying to fix them might be confusing
There was a problem hiding this comment.
We would have to add 4-5 stages (note: Functional Cluster Box Medium MD on SSD already exists):
-
daily-testing
- Functional Cluster Box Medium
- Functional Cluster Box Medium Verbs Provider
- Functional Cluster Box Medium Verbs Provider MD on SSD
- Functional Cluster Box Medium UCX Provider
- Functional Cluster Box Medium VMD (potentially if more cb tests added)
I see an advantage to having a daily run of a
cbtagged test on HW. One that can be used to compare if failures are seen on CB or HW and not vice-versa.
| label: params.FUNCTIONAL_HARDWARE_MEDIUM_LABEL, | ||
| next_version: next_version(), | ||
| stage_tags: 'hw,medium,-provider', | ||
| stage_tags: 'hw,medium,-provider,-cb', |
There was a problem hiding this comment.
This is also needed on the other Functional Hardware Medium * stages:
- Functional Hardware Medium
- Functional Hardware Medium VMD
- Functional Hardware Medium UCX Provider
3 participants
This change changes the strategy slightly between hw and cb test tags. All cb tests can run on hw stages as well. Filter out cb tags on HW stages where there is clear cb coverage.
Steps for the author:
After all prior steps are complete: