Skip to content

chore: fix clippy warnings and apply rustfmt - #20

Open
nyurik wants to merge 1 commit into
dapper91:masterfrom
nyurik:cleanup
Open

nyurik wants to merge 1 commit into
dapper91:masterfrom
nyurik:cleanup

Conversation

@nyurik

@nyurik nyurik commented Oct 7, 2026

Copy link
Copy Markdown

No functional change. cargo clippy --all-targets --all-features -- -D warnings now passes and cargo fmt --check is clean, so follow-up changes can be reviewed against a warning-free baseline.

  • Drop redundant return statements and use lines of extern crates, and needless borrows and into_iter() calls.
  • Add a default ChunkBuffer::is_empty (clippy's len_without_is_empty); existing implementations keep compiling.
  • Name the long types clippy flags as too complex: HeapItem in the merger, ChunkSortError and SortResult in the sorter.
  • Tests: assert! instead of assert_eq! with booleans, and io::Error::other.
  • Reformat with the repository's rustfmt.toml.

No functional change. `cargo clippy --all-targets --all-features -- -D
warnings` now passes and `cargo fmt --check` is clean, so follow-up
changes can be reviewed against a warning-free baseline.

- Drop redundant `return` statements and `use` lines of extern crates,
  and needless borrows and `into_iter()` calls.
- Add a default `ChunkBuffer::is_empty` (clippy's `len_without_is_empty`);
  existing implementations keep compiling.
- Name the long types clippy flags as too complex: `HeapItem` in the
  merger, `ChunkSortError` and `SortResult` in the sorter.
- Tests: `assert!` instead of `assert_eq!` with booleans, and
  `io::Error::other`.
- Reformat with the repository's `rustfmt.toml`.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant