Open
Conversation
When dapr receives a termination signal, the app process gets killed without printing "Exited App successfully". The executeAgainstRunningDapr helper previously required this message whenever an app command was present. Accept "terminated signal received: shutting down" as a valid shutdown path that doesn't require a clean app exit message. Signed-off-by: joshvanl <me@joshvanl.dev>
There was a problem hiding this comment.
Pull request overview
Updates the E2E standalone test helper to treat Dapr shutdowns initiated by a termination signal as a valid/expected path, reducing flakiness when the app process is killed before emitting a clean “Exited App successfully” message.
Changes:
- Detects
terminated signal received: shutting downindapr runoutput. - Treats that termination-signal path as acceptable when determining whether
dapr runexited cleanly. - Skips the strict requirement for
Exited App successfullywhen shutdown was signal-driven.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Signed-off-by: joshvanl <me@joshvanl.dev>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1610 +/- ##
==========================================
- Coverage 15.45% 15.43% -0.03%
==========================================
Files 64 64
Lines 7220 7230 +10
==========================================
Hits 1116 1116
- Misses 6018 6028 +10
Partials 86 86 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: joshvanl <me@joshvanl.dev>
Signed-off-by: joshvanl <me@joshvanl.dev>
Signed-off-by: joshvanl <me@joshvanl.dev>
acroca
reviewed
Mar 18, 2026
Signed-off-by: joshvanl <me@joshvanl.dev>
acroca
previously approved these changes
Mar 19, 2026
Signed-off-by: joshvanl <me@joshvanl.dev>
Signed-off-by: joshvanl <me@joshvanl.dev>
Signed-off-by: joshvanl <me@joshvanl.dev>
Signed-off-by: joshvanl <me@joshvanl.dev>
Signed-off-by: joshvanl <me@joshvanl.dev>
acroca
reviewed
Mar 20, 2026
Signed-off-by: joshvanl <me@joshvanl.dev>
Signed-off-by: joshvanl <me@joshvanl.dev>
After cmdStopWithRunTemplate sends SIGTERM and the CLI exits, child processes may hold pipe file descriptors open, causing CombinedOutput to block until the context timeout. Fix by calling cancel() after stop so WaitDelay (10s) forces CombinedOutput to return. For env_var_not_set and wrong_emit_metrics: wait for daprd log to confirm shutdown (triggered by app crash) instead of stopping before the app has time to compile and fail with the expected error. Signed-off-by: joshvanl <me@joshvanl.dev>
Signed-off-by: joshvanl <me@joshvanl.dev>
Signed-off-by: joshvanl <me@joshvanl.dev>
Signed-off-by: joshvanl <me@joshvanl.dev>
acroca
reviewed
Mar 25, 2026
| // NOTE: Do NOT use waitForAppsListed here — dapr list detects | ||
| // the daprd process running BEFORE the CLI finishes health | ||
| // checks, causing a race where stop is sent too early. | ||
| waitForLogContent(t, "../../apps/emit-metrics/.dapr/logs", "daprd", "You're up and running!", 180*time.Second) |
Member
There was a problem hiding this comment.
Can't we wait for the apps to be healthy?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When dapr receives a termination signal, the app process gets killed without printing "Exited App successfully". The executeAgainstRunningDapr helper previously required this message whenever an app command was present.
Accept "terminated signal received: shutting down" as a valid shutdown path that doesn't require a clean app exit message.