Skip to content

Fix CI build#979

Merged
sicoyle merged 1 commit intodapr:mainfrom
acroca:fix-build
Apr 14, 2026
Merged

Fix CI build#979
sicoyle merged 1 commit intodapr:mainfrom
acroca:fix-build

Conversation

@acroca
Copy link
Copy Markdown
Member

@acroca acroca commented Apr 14, 2026

We're having some build failure sin main: #978

Signed-off-by: Albert Callarisa <albert@diagrid.io>
@acroca acroca requested review from a team as code owners April 14, 2026 11:30
@acroca acroca requested a review from Copilot April 14, 2026 11:31
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses CI build failures on main by tightening type information around protobuf Any.Is(...) checks in the gRPC helpers, likely resolving static type-checking failures introduced by recent dependency/stub changes.

Changes:

  • Add cast and Descriptor imports for protobuf descriptor typing.
  • Cast message.DESCRIPTOR to Descriptor when calling GrpcAny.Is(...) in unpack().

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.39%. Comparing base (bffb749) to head (69822b6).
⚠️ Report is 100 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #979      +/-   ##
==========================================
- Coverage   86.63%   80.39%   -6.24%     
==========================================
  Files          84      136      +52     
  Lines        4473    12590    +8117     
==========================================
+ Hits         3875    10122    +6247     
- Misses        598     2468    +1870     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@sicoyle sicoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!!

@sicoyle sicoyle added this pull request to the merge queue Apr 14, 2026
Merged via the queue into dapr:main with commit cb68754 Apr 14, 2026
18 of 19 checks passed
@acroca acroca deleted the fix-build branch April 14, 2026 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants