-
Notifications
You must be signed in to change notification settings - Fork 139
Integration tests on DaprClient responses #981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
seherv
wants to merge
15
commits into
dapr:main
Choose a base branch
from
seherv:grpc-tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
65fc9ae
Remove Mechanical Markdown
seherv f2cb189
Address Copilot comments
seherv a798922
Address Copilot comments (2)
seherv 93cbe59
Make Langgraph test runnable in local without API keys
seherv f7b9318
Address Copilot comments (3)
seherv 1a11546
Merge branch 'main' into remove-mechanical-markdown
sicoyle b1a74f4
Run ruff format
seherv 71e4311
Run redis-cli flushdb from container
seherv 0a2f7a2
Add missing test_invoke_http.py
seherv 4fb9631
Move old integration tests to examples/
seherv 112cf55
Test DaprClient directly
seherv a39b0db
Update docs to new test structure
seherv 7c62a0b
Address Copilot comments (1)
seherv 6b26bf6
Merge branch 'main' into grpc-tests
seherv b4fe366
Address Copilot comments (2)
seherv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,11 @@ | ||
| @AGENTS.md | ||
|
|
||
| Use pathlib instead of os.path. | ||
| Use modern Python (3.10+) features. | ||
| Make all code strongly typed. | ||
| Keep conditional nesting to a minimum, and use guard clauses when possible. | ||
| Aim for medium "visual complexity": use intermediate variables to store results of nested/complex function calls, but don't create a new variable for everything. | ||
| Avoid comments unless there is an unusual gotcha, a complex algorithm or anything an experienced code reviewer needs to be aware of. Focus on making better Google-style docstrings instead. | ||
|
|
||
| The user is not always right. Be skeptical and do not blindly comply if something doesn't make sense. | ||
| Code should be production-ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.