Use System.Security.Cryptography.Cng only with netstandard2.0 - #20
Closed
tinohager wants to merge 1 commit into
Closed
Use System.Security.Cryptography.Cng only with netstandard2.0#20tinohager wants to merge 1 commit into
tinohager wants to merge 1 commit into
Conversation
darinkes
reviewed
Sep 9, 2025
|
|
||
| <PackageReference Include="SSH.NET" Version="[2024.2.0,)" /> | ||
| <PackageReference Include="Konscious.Security.Cryptography.Argon2" Version="1.3.0"/> | ||
| <PackageReference Include="SSH.NET" Version="2025.0.0" /> |
Owner
There was a problem hiding this comment.
This should stay in the minimal required format.
| <PropertyGroup> | ||
| <TargetFrameworks Condition="'$(OS)' == 'Windows_NT'">net48;netstandard2.0</TargetFrameworks> | ||
| <TargetFramework Condition="'$(OS)' != 'Windows_NT'">netstandard2.0</TargetFramework> | ||
| <TargetFrameworks Condition="'$(OS)' == 'Windows_NT'">net48;netstandard2.0;net8</TargetFrameworks> |
Owner
There was a problem hiding this comment.
I think this can be adjusted to match SSH.NET:
<TargetFrameworks>net462;netstandard2.0;net8.0;net9.0</TargetFrameworks>
| <ItemGroup Condition=" '$(TargetFramework)' != 'net48' "> | ||
| <PackageReference Include="System.Security.Cryptography.Cng" Version="5.0.0" /> | ||
| </ItemGroup> | ||
| <ItemGroup Condition=" '$(TargetFramework)' == 'netstandard2.0' "> |
Owner
There was a problem hiding this comment.
SSH.NET uses this, should work here too, right?
<ItemGroup Condition=" !$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net8.0')) ">
<PackageReference Include="System.Formats.Asn1" />
</ItemGroup>
| <TargetFrameworks Condition="'$(OS)' == 'Windows_NT'">net48;netstandard2.0</TargetFrameworks> | ||
| <TargetFramework Condition="'$(OS)' != 'Windows_NT'">netstandard2.0</TargetFramework> | ||
| <TargetFrameworks Condition="'$(OS)' == 'Windows_NT'">net48;netstandard2.0;net8</TargetFrameworks> | ||
| <TargetFrameworks Condition="'$(OS)' != 'Windows_NT'">netstandard2.0;net8</TargetFrameworks> |
Owner
|
Thanks for this, @tinohager, and sorry it sat so long. Closing because the tree has moved past most of it:
The one piece still worth doing is adding a net8.0 target (with CNG scoped to netstandard2.0). We'll pick that up as a focused change. Really appreciate the contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If I understand correctly, we only need “System.Security.Cryptography.Cng” for .netstandard2.0. Perhaps we can define the dependency so that it only comes into play in that case.