[WIP] Add full test case for variadic delayed Matrix allocation#420
Open
devreal wants to merge 6 commits intodevelopmentfrom
Open
[WIP] Add full test case for variadic delayed Matrix allocation#420devreal wants to merge 6 commits intodevelopmentfrom
devreal wants to merge 6 commits intodevelopmentfrom
Conversation
Member
Author
|
Hmpf, the error is not triggered in CI. Here is what I see on my laptop: |
Contributor
|
I can report the same error, for me it even triggers in the first test I tried to debug it a little bit and it seems to fail in |
Member
Author
|
The main issue has been fixed in #444 (thanks to @fmoessbauer). What is left in this PR is splitting the test for variadic matrix allocation into a separate test case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@fuchsto: Please have a look at this. Your test
MatrixTest.DelayedAllocsucceeds while the new testMatrixTest.VariadicDelayedAllocfails while checking the validity of the pattern arguments, which are the same as in the first test. So either the first test case is invalid or the check inPatternArgumentsis overly strict. I cannot decide that :)