fix(controller): return deployment names from retire_workers - #978
Open
omykhailenkopelmorex wants to merge 2 commits into
Open
omykhailenkopelmorex wants to merge 2 commits into
omykhailenkopelmorex wants to merge 2 commits into
Conversation
omykhailenkopelmorex
force-pushed
the
main
branch
from
September 8, 2026 11:15
5805232 to
a5c0ec3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey Dask team, I tried investigating #855, and found out that the
retire_workerscode is pretty weird – it tries to retire workers on scheduler via HTTP/RPC, and then returns "worker ids" that were retired. In both the HTTP API case and RPC case, those worker ids are in fact TCP socket addresses ("tcp://worker-host:port"), while at the very end of the function the deployment names are returned. Instead of doing that, we first get a mapping of pod IPs to deployment names, then retire workers via scheduler, get the addresses of retired workers, and then we return deployment names which own those workers. This PR fixed the scale down phase on our cluster. PTAL and let me know if I should do any changes.