Repository navigation
Reject conflicting KubeCluster options when using a custom cluster spec - #979
Open
ajiteshbankulaa wants to merge 2 commits into
Open
ajiteshbankulaa wants to merge 2 commits into
ajiteshbankulaa wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When
custom_cluster_specis provided,KubeClusteruses that spec only. Even though Constructor options such asidle_timeoutwere still accepted, they had no effect. For example, passingidle_timeout=30alongside a custom spec withidleTimeout: 0would leave the timeout at0.This change I made it such that it raises a
ValueErrorwhen a custom spec is combined with options that belong in the spec. The error tells users to set those values in the custom spec or pass them tomake_cluster_spec(). It also covers custom specs supplied through Dask configuration.I updated the existing custom spec tests to put their options in
make_cluster_spec()and added tests for the conflicting arguments.This addresses the ignored arguments discussed in #882. The missing key timer exception was addressed separately in #884.