Remove error stacktrace from failure collector#355
Open
harishhk107 wants to merge 1 commit into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the stack trace from a validation failure message in SalesforceSourceConfig.java when a ConnectionException is encountered. The review feedback points out that this change introduces an inconsistency with other error handling blocks in the same class and related utility files, suggesting that the removal of stack traces should be applied consistently across all relevant call sites for a uniform user experience.
harishhk107
force-pushed
the
fix/remove-error-stacktrace
branch
from
b440927 to
d085f8e
Compare
harishhk107
force-pushed
the
fix/remove-error-stacktrace
branch
from
d085f8e to
c9fa4b5
Compare
vikasrathee-cs
changed the title
vikasrathee-cs
force-pushed
the
fix/remove-error-stacktrace
branch
from
c9fa4b5 to
05f84c6
Compare
vikasrathee-cs
force-pushed
the
fix/remove-error-stacktrace
branch
from
05f84c6 to
c1e11ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During configuration validation in
SalesforceSourceConfigandSalesforceConnectionUtil, attaching a Java exception stack trace (.withStacktrace()) to validation failures caused the hosting runtime (Connectors Service) to classify user configuration errors as internal system faults.Removing
.withStacktrace()consistently across these validation call sites ensures the runtime correctly treats configuration failures as standard user errors, successfully propagating exact Salesforce error messages and error IDs to the client.This stack trace was exposing a lot of user information which is not required to debug or get the root cause of the issue.