Skip to content

[Cherrypick] [PLUGIN-1953] Support for client credentials Grant type and bump up to 1.7.4-SNAPSHOT#356

Open
vikasrathee-cs wants to merge 2 commits into
release/1.7from
client_cred_rel7
Open

[Cherrypick] [PLUGIN-1953] Support for client credentials Grant type and bump up to 1.7.4-SNAPSHOT#356
vikasrathee-cs wants to merge 2 commits into
release/1.7from
client_cred_rel7

Conversation

@vikasrathee-cs
Copy link
Copy Markdown
Contributor

@vikasrathee-cs vikasrathee-cs commented May 18, 2026

[Cherrypick] PLUGIN-1953 Support for client credentials Grant type and bump up to 1.7.4-SNAPSHOT

Cherrypick CL #353

@google-cla
Copy link
Copy Markdown

google-cla Bot commented May 18, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for the 'client_credentials' OAuth grant type to Salesforce plugins, including updates to documentation, UI widgets, and validation logic. Key feedback involves refining the field description for clarity, making the security token optional for the password grant type to support IP whitelisting, and re-adding null checks for authentication fields in the format providers to avoid potential NullPointerExceptions.

public class SalesforceConnectorBaseConfig extends PluginConfig {

@Name(SalesforceConstants.PROPERTY_AUTHENTICATION_GRANT_TYPE)
@Description("Salesforce authentication grant type: basic or client credentials")
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The description mentions 'basic' as a grant type, but the supported values are 'password' and 'client_credentials'. It would be clearer to use 'password' instead of 'basic' to match the actual configuration values and the UI labels.

Suggested change
@Description("Salesforce authentication grant type: basic or client credentials")
@Description("Salesforce authentication grant type: password or client credentials")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a valid comment, can we please fix this in develop and release branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants