[Cherrypick] [PLUGIN-1953] Support for client credentials Grant type and bump up to 1.7.4-SNAPSHOT#356
[Cherrypick] [PLUGIN-1953] Support for client credentials Grant type and bump up to 1.7.4-SNAPSHOT#356vikasrathee-cs wants to merge 2 commits into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request adds support for the 'client_credentials' OAuth grant type to Salesforce plugins, including updates to documentation, UI widgets, and validation logic. Key feedback involves refining the field description for clarity, making the security token optional for the password grant type to support IP whitelisting, and re-adding null checks for authentication fields in the format providers to avoid potential NullPointerExceptions.
| public class SalesforceConnectorBaseConfig extends PluginConfig { | ||
|
|
||
| @Name(SalesforceConstants.PROPERTY_AUTHENTICATION_GRANT_TYPE) | ||
| @Description("Salesforce authentication grant type: basic or client credentials") |
There was a problem hiding this comment.
The description mentions 'basic' as a grant type, but the supported values are 'password' and 'client_credentials'. It would be clearer to use 'password' instead of 'basic' to match the actual configuration values and the UI labels.
| @Description("Salesforce authentication grant type: basic or client credentials") | |
| @Description("Salesforce authentication grant type: password or client credentials") |
There was a problem hiding this comment.
This looks like a valid comment, can we please fix this in develop and release branch?
[Cherrypick] PLUGIN-1953 Support for client credentials Grant type and bump up to 1.7.4-SNAPSHOT
Cherrypick CL #353