Merged
Conversation
Add basic table for similar bed files and pdf download button for plots
Added endpoint and ui modal that creates bedsets
Deploying bedhost-ui with
|
| Latest commit: |
1215618
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://17e50dda.bedhost.pages.dev |
| Branch Preview URL: | https://dev.bedhost.pages.dev |
nleroy917
requested changes
Dec 20, 2024
Member
nleroy917
left a comment
nleroy917
left a comment
There was a problem hiding this comment.
Lots to go through... I did the best I could. I trust the CSS changes look ok and make sense, so I was just focused more on logic, TypeScript, and python stuff
Comment on lines
+55
to
+64
| const handleSubmit = async () => { | ||
| try { | ||
| await axios.post(API_ENDPOINT, { registry_path: inputValue }); | ||
| setMessage('Successfully created BEDset!'); | ||
| } catch (error) { | ||
| const err = error as Error & { response?: { data?: { detail?: string } } }; | ||
| const errorMessage = err.response?.data?.detail || err.message; | ||
| setMessage(`! Unable to create BEDset. ${errorMessage}`); | ||
| } | ||
| }; |
Member
There was a problem hiding this comment.
Bigger discussion than a PR review, but we probably eventually want to convert this to a useMutation implementation. Also, can anyone submit a bedset?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
bedhostbackend and the UI components. The most important changes include the addition of new API endpoints, refactoring of existing code, and updates to the UI for better user experience.Changes:
CreateBEDsetRequestinbedhost/data_models.pyto handle BEDset creation requests./v1/bed/{bed_id}/neighboursto get nearest neighbors for a BED record inbedhost/routers/bed_api.py./v1/bedset/create/to create a new BEDset by providing a registry path to the PEPhub project inbedhost/routers/bedset_api.py.text_to_bed_searchfunction to include additional logic for handling specific queries inbedhost/routers/bed_api.py.UI Changes:
Download pdfbutton for plots