Skip to content

test: cover bundle-add-pipeline loaders, dispatch, and validation - #514

Merged
ravi-databricks merged 1 commit into
v0.1.1from
release_v0.1.1_code_coverage
Nov 4, 2026
Merged

ravi-databricks merged 1 commit into
v0.1.1from
release_v0.1.1_code_coverage

Conversation

@ravi-databricks

Copy link
Copy Markdown
Contributor

Add unit tests for the bundle-add-pipeline path that Codecov flagged as uncovered, bringing project coverage back above the 90% floor enforced in onboard.yml (89.77% -> 92.53%).

  • Cover the interactive _load_bundle_add_pipeline_config prompts for bronze, silver, bronze_silver split, and combined layers, including dry-run selection.
  • Cover the cli.bundle_add_pipeline dispatcher on success and on a non-zero runner exit.
  • Cover early-return errors in bundle_add_pipeline: non-bundle directory, missing pipeline spec, and missing sdp_meta_pipelines.yml.
  • Cover the dry-run success path, asserting no files are written.
  • Cover PipelineSpec.post_init validation for name, layer, mode, combined-layer constraint, and empty dataflow_group.

Add unit tests for the bundle-add-pipeline path that Codecov flagged
as uncovered, bringing project coverage back above the 90% floor
enforced in onboard.yml (89.77% -> 92.53%).

- Cover the interactive _load_bundle_add_pipeline_config prompts for
  bronze, silver, bronze_silver split, and combined layers, including
  dry-run selection.
- Cover the cli.bundle_add_pipeline dispatcher on success and on a
  non-zero runner exit.
- Cover early-return errors in bundle_add_pipeline: non-bundle
  directory, missing pipeline spec, and missing sdp_meta_pipelines.yml.
- Cover the dry-run success path, asserting no files are written.
- Cover PipelineSpec.__post_init__ validation for name, layer, mode,
  combined-layer constraint, and empty dataflow_group.

@brij-raghuwanshi-db brij-raghuwanshi-db left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good.

@ravi-databricks
ravi-databricks merged commit 7b994bb into v0.1.1 Nov 4, 2026
8 checks passed
@codecov

codecov Bot commented Nov 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.14%. Comparing base (40dac63) to head (8e311be).
⚠️ Report is 2 commits behind head on v0.1.1.

Additional details and impacted files
@@            Coverage Diff             @@
##           v0.1.1     #514      +/-   ##
==========================================
+ Coverage   89.29%   90.14%   +0.85%     
==========================================
  Files          18       18              
  Lines        5043     5043              
  Branches     1033     1033              
==========================================
+ Hits         4503     4546      +43     
+ Misses        313      279      -34     
+ Partials      227      218       -9     
Flag Coverage Δ
unittests 90.14% <ø> (+0.85%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants