Repository navigation
test: cover bundle-add-pipeline loaders, dispatch, and validation - #514
Merged
Merged
Conversation
Add unit tests for the bundle-add-pipeline path that Codecov flagged as uncovered, bringing project coverage back above the 90% floor enforced in onboard.yml (89.77% -> 92.53%). - Cover the interactive _load_bundle_add_pipeline_config prompts for bronze, silver, bronze_silver split, and combined layers, including dry-run selection. - Cover the cli.bundle_add_pipeline dispatcher on success and on a non-zero runner exit. - Cover early-return errors in bundle_add_pipeline: non-bundle directory, missing pipeline spec, and missing sdp_meta_pipelines.yml. - Cover the dry-run success path, asserting no files are written. - Cover PipelineSpec.__post_init__ validation for name, layer, mode, combined-layer constraint, and empty dataflow_group.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v0.1.1 #514 +/- ##
==========================================
+ Coverage 89.29% 90.14% +0.85%
==========================================
Files 18 18
Lines 5043 5043
Branches 1033 1033
==========================================
+ Hits 4503 4546 +43
+ Misses 313 279 -34
+ Partials 227 218 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add unit tests for the bundle-add-pipeline path that Codecov flagged as uncovered, bringing project coverage back above the 90% floor enforced in onboard.yml (89.77% -> 92.53%).