Skip to content

Reindex touched dois daily#5

Merged
bklaing2 merged 5 commits into
mainfrom
reindex-touched-dois-daily
Jul 9, 2026
Merged

Reindex touched dois daily#5
bklaing2 merged 5 commits into
mainfrom
reindex-touched-dois-daily

Conversation

@bklaing2

@bklaing2 bklaing2 commented Jul 2, 2026

Copy link
Copy Markdown
Member

Purpose

The lambda that queues messages for datacite/events#88

Introduces a helper script and docker-compose. Example command:

./run_lambda.sh lambdas/events_queue_reindex_touched_dois/events_queue_reindex_touched_dois_runner.py QUEUE_NAME=development_events

closes: Add github issue that originated this PR

Approach

Open Questions and Pre-Merge TODOs

Learning

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

@bklaing2 bklaing2 self-assigned this Jul 2, 2026
@bklaing2 bklaing2 requested review from a team and richardhallett July 7, 2026 22:07
@bklaing2 bklaing2 marked this pull request as ready for review July 7, 2026 22:07

@richardhallett richardhallett left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally fine, ideally should add to the build.sh so the zip file can be generated that you'll need in mastino.

Comment thread run_lambda.sh

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While fine, this seems a little more complicated than needed.

You could specify the AWS localstack env variables in a .env and load this in the docker compose.
The only KEY being passed through to running is QUEUE_NAME, which again is probably always same for local testing and can be defined in the .env

So instead of running this SH, you could just run the docker compose run directly.

@bklaing2 bklaing2 Jul 8, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree it was a bit overkill. I've simplified the script, but for the moment it is still necessary to extract the LAMBDA_DIR/PATH variables needed in docker-compose.yml.

@bklaing2 bklaing2 requested a review from richardhallett July 8, 2026 19:31
@bklaing2 bklaing2 merged commit 22cdf01 into main Jul 9, 2026
1 check passed
@bklaing2 bklaing2 deleted the reindex-touched-dois-daily branch July 9, 2026 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants