Reindex touched dois daily#5
Conversation
richardhallett
left a comment
There was a problem hiding this comment.
Generally fine, ideally should add to the build.sh so the zip file can be generated that you'll need in mastino.
There was a problem hiding this comment.
While fine, this seems a little more complicated than needed.
You could specify the AWS localstack env variables in a .env and load this in the docker compose.
The only KEY being passed through to running is QUEUE_NAME, which again is probably always same for local testing and can be defined in the .env
So instead of running this SH, you could just run the docker compose run directly.
There was a problem hiding this comment.
I agree it was a bit overkill. I've simplified the script, but for the moment it is still necessary to extract the LAMBDA_DIR/PATH variables needed in docker-compose.yml.
Purpose
The lambda that queues messages for datacite/events#88
Introduces a helper script and
docker-compose. Example command:closes: Add github issue that originated this PR
Approach
Open Questions and Pre-Merge TODOs
Learning
Types of changes
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Reviewer, please remember our guidelines: