Skip to content

Fix secret_key_base must exist#88

Merged
richardhallett merged 1 commit into
masterfrom
fix_secret_base_key
Jun 15, 2026
Merged

Fix secret_key_base must exist#88
richardhallett merged 1 commit into
masterfrom
fix_secret_base_key

Conversation

@richardhallett

Copy link
Copy Markdown
Contributor

This needs to exist for the application to boot. We do not use rails sessions so it's just set to a hardcoded value.

Purpose

Fixes poodle

Approach

By returning the original config of setting the secret_key_base

Open Questions and Pre-Merge TODOs

N/A

Learning

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to change)

Reviewer, please remember our guidelines:

  • Be humble in the language and feedback you give, ask don't tell.
  • Consider using positive language as opposed to neutral when offering feedback. This is to avoid the negative bias that can occur with neutral language appearing negative.
  • Offer suggestions on how to improve code e.g. simplification or expanding clarity.
  • Ensure you give reasons for the changes you are proposing.

This needs to exist for the application to boot. We do not use rails
sessions so it's just set to a hardcoded value.
@richardhallett richardhallett requested a review from a team June 15, 2026 13:27
@richardhallett richardhallett self-assigned this Jun 15, 2026
@richardhallett richardhallett merged commit b6e88d2 into master Jun 15, 2026
2 checks passed
@richardhallett richardhallett deleted the fix_secret_base_key branch June 15, 2026 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants