Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2019.
When resolving
localpackage._ast, the builtin importer receives the leaf name_astand ignores the package search path. It claims the top-level builtin before the path finder can find the real package module, so inference and goto return no definition. Skip the builtin importer for package searches while retaining its precedence for top-level imports.Eight regression cases cover
_astandsys, ordinary modules and packages, and absolute and relative imports. They check inference, goto, completion, and unchanged top-level builtin resolution. All eight fail against the original source and pass with this change.One existing namespace test now explicitly uses its temporary directory as the Project root. This makes it independent of a Git checkout above the temporary directory; its assertions are unchanged. The original source with only that fixture adjustment passes the complete suite (4,014 tests).
Validation on Linux / CPython 3.12.14:
The skips/xfails are existing repository markers. Optional strict Twine warns about the existing missing description-content-type metadata; the separately enabled, normally unconfigured Sphinx doctest builder has the same 17 failures on original and patched code. Neither is presented as a passing required check. Other platforms and Python versions were not validated as a full matrix.
Prepared with OpenAI Codex assistance.