Repository navigation
Conversation
|
This is related to issue #200. |
|
Hey, this is great - could you just make it warn if it gets inconsistent data; meaning in the case that the postgres gets weird data where the case insensitive flag is on for a non-text col, it should proceed to make it citext but at least warn |
|
Thanks for the prompt review. I've added the warning now (only for Pg; SQLite seems to accept the option for any type of field). This means that the test is (rightly) emitting a warning - would you like me to try and silence that somehow? |
|
best option is to assert that the test warns :) |
Makes sense! Well, I learnt a new module today, I assume |
|
Any chance of merging this please..? :-) |
|
Ping... Let me know if any other changes need making. Many thanks |
This PR adds a field option for case-insensitivity. Whilst this behavior would normally be controlled with collation options, some databases have case-specific options or extensions and it is useful to be able to support these. In my case, I am using
SQL::Translatorto deploy to a SQLite database and theCOLLATE NOCASEoptions need to be provided as part of the field creation.Comments/thoughts welcome if there is a better way to achieve this.