Repository navigation
fix: group ability card header attributes under Headers - #458
Merged
LVL1024 merged 2 commits intoOct 5, 2026
Merged
Conversation
Collaborator
Author
|
The wiki side ability cards stuff will need to be updated to make use of stats, but I haven't really messed with ability cards there. So hopefully you could update that once this is approved if it's not too much of a hassle. @hassayag |
Member
|
@LVL1024 Nice addition. I think to help with the scripting side I would suggest putting all the header data in a "Headers" attribute. Happy to deal with the breakage on the wiki side |
Collaborator
Author
Done, moved everything into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ability card headers were built from a hardcoded list of attribute names, so stats whose header attribute uses a non-standard name were dropped into the wrong section of the card. This is why Graves' Grasping Hands was missing its wall length (
ZombieWallLength).Ability cards now also read
m_AbilityTooltipDetails.m_vecAdditionalHeaderProperties, the game's own list of extra header attributes, and group all header attributes (standard and additional) under a singleHeadersobject. This also fixes the same issue for other abilities, e.g. Seismic Impact (ImpactRadius), Love Bites (PerTargetCooldown), Jar of Dead (SkullLifetime), Flawless Advance (SlashLength) and Itani Lo Sahn (DashRange).Note: the standard header stats (
AbilityCooldown,AbilityDuration, etc.) move out of the card root and intoHeaders.Closes #327
Parsed data in deadlock-data PR - Reopen deadbot PR or run deploy workflow for this branch here to reparse the data