Skip to content

fix: group ability card header attributes under Headers - #458

Merged
LVL1024 merged 2 commits into
developfrom
bugfix/ability-card-additional-header-properties
Oct 5, 2026
Merged

LVL1024 merged 2 commits into
developfrom
bugfix/ability-card-additional-header-properties

Conversation

@LVL1024

@LVL1024 LVL1024 commented Oct 5, 2026 •

Copy link
Copy Markdown
Collaborator

Ability card headers were built from a hardcoded list of attribute names, so stats whose header attribute uses a non-standard name were dropped into the wrong section of the card. This is why Graves' Grasping Hands was missing its wall length (ZombieWallLength).

Ability cards now also read m_AbilityTooltipDetails.m_vecAdditionalHeaderProperties, the game's own list of extra header attributes, and group all header attributes (standard and additional) under a single Headers object. This also fixes the same issue for other abilities, e.g. Seismic Impact (ImpactRadius), Love Bites (PerTargetCooldown), Jar of Dead (SkullLifetime), Flawless Advance (SlashLength) and Itani Lo Sahn (DashRange).

Note: the standard header stats (AbilityCooldown, AbilityDuration, etc.) move out of the card root and into Headers.

Closes #327

Parsed data in deadlock-data PR - Reopen deadbot PR or run deploy workflow for this branch here to reparse the data

@LVL1024

LVL1024 commented Oct 5, 2026

Copy link
Copy Markdown
Collaborator Author

The wiki side ability cards stuff will need to be updated to make use of stats, but I haven't really messed with ability cards there. So hopefully you could update that once this is approved if it's not too much of a hassle. @hassayag

@hassayag

hassayag commented Oct 5, 2026

Copy link
Copy Markdown
Member

@LVL1024 Nice addition. I think to help with the scripting side I would suggest putting all the header data in a "Headers" attribute. Happy to deal with the breakage on the wiki side

@LVL1024 LVL1024 changed the title fix: include additional header attributes in ability cards fix: group ability card header attributes under Headers Oct 5, 2026
@LVL1024

LVL1024 commented Oct 5, 2026

Copy link
Copy Markdown
Collaborator Author

@LVL1024 Nice addition. I think to help with the scripting side I would suggest putting all the header data in a "Headers" attribute. Happy to deal with the breakage on the wiki side

Done, moved everything into Headers. Let me know if it looks good.

@hassayag hassayag left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lush 🚀

@LVL1024
LVL1024 merged commit 195446d into develop Oct 5, 2026
5 checks passed
@LVL1024
LVL1024 deleted the bugfix/ability-card-additional-header-properties branch October 5, 2026 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Graves Grasping Hands missing wall length

2 participants