chore: instrument AltTester main-thread stalls - #10041
Draft
mikhail-dcl wants to merge 1 commit into
Draft
mikhail-dcl wants to merge 1 commit into
mikhail-dcl wants to merge 1 commit into
Conversation
Contributor
🚦 CI StatusWindows and Mac built successfully in Unity Cloud.
No C# files changed — lint ratchet skipped. Waiting for tests to start… 🏁 Bare-metal benchmark finished — run #34403549655. Full reportPR #10041, run #34403549655 Overall: ✅ no significant changes Builds: Windows change, Windows baseline, macOS change, macOS baseline How to read this table
Intel Core i5
On demand — comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Pin the AltTester fork to 0aa90e29, adding opt-in background main-thread stage diagnostics to distinguish screenshot capture/encoding from socket-send stalls. Based on Explorer 9d6e552 for comparison with the measured failing build; SDK Unity 6.5 compatibility remains intact and upstream PR1984 is unchanged. Diagnostic only; no stall fix claimed.
Test Instructions
In PowerShell, set
$env:ALTTESTER_MAIN_THREAD_DIAGNOSTICS='1', then run this PR's Windows build with the InWorld suite. Inspect%USERPROFILE%/AppData/LocalLow/Decentraland/Explorer/AltTesterMainThread.tsvalongside the Player log and per-test performance report. During a stall, compare heartbeat age, active stage and pending frame wait; without the environment variable, no watchdog should start.Validation: SDK's 15 source-linked diagnostic assertions passed; manifest and lock pin match. Unity build and CI reproduction pending.
Quality Checklist