Skip to content

Physical dependencies cleanup - #456

Open
gshigin wants to merge 1 commit into
ppfrom
dependencies-cleanup
Open

Physical dependencies cleanup#456
gshigin wants to merge 1 commit into
ppfrom
dependencies-cleanup

Conversation

@gshigin

@gshigin gshigin commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

Dependencies cleanup. Removed non-used includes (mostly from tests), also restructured Bazel dependencies. It showed, that 2 non-existent dependencies can be removed: series_index -> wal and entrypoint_types -> head.

Shouldn't affect any program behaviour.

@gshigin gshigin added this to the next milestone Jul 29, 2026
@gshigin
gshigin requested review from cherep58 and vporoshok July 29, 2026 13:14
@gshigin gshigin self-assigned this Jul 29, 2026
@cherep58

Copy link
Copy Markdown
Collaborator

How you find unused includes? Include What You Use ???

@gshigin

gshigin commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator Author

How you find unused includes? Include What You Use ???

I've turned on misc-include-cleaner option in clang-tidy. iwyu is much more heavy tool and does much more, also it includes some controversial features like proposing forward declarations or direct include of headers with symbol declaration. I wanted only cleanup to remove unused dependencies. So misc-include-cleaner did the work

@cherep58

Copy link
Copy Markdown
Collaborator

Maybe we add misc-include-cleaner to our .clang-tidy config?

@gshigin gshigin removed this from the next milestone Aug 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants