fix: isolate user-created topics in regular groups - #630
Closed
hu5h wants to merge 2 commits into
Closed
Conversation
fix: isolate user-created topics in regular groups
Author
|
Superseded by #631, which ports the same focused change onto the latest upstream master and is mergeable. Closing this conflicting fork-master PR to keep review on the clean branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
message_id, then reuseroot_idfor later replies.sharedreply mode.Problem
Regular groups normally use one chat-scoped session. When a user explicitly creates an independent Lark topic, its root event can contain
thread_id=omt_*withoutroot_id. That root previously fell through to the regular-group routing policy and reused the group session, so the topic did not have isolated context.Implementation
source=topic-chat, while only ordinary-group topic roots becomereal-threadsessions.sharedmode from folding an explicit user-created topic root back into the group session.Validation
pnpm vitest run test/event-dispatcher.test.ts— 121/121 passedpnpm exec tsc --noEmit— passedpnpm build— passedgit diff --check— passedSource
Merged and validated first in hu5h#1 (
6dbc20c7).