feat: DH-20323: Add reserve_bits parameter for cross joins and outer joins in Python#8266
Merged
jmao-denver merged 10 commits intoJul 24, 2026
Merged
Conversation
jmao-denver
added
python
NoDocumentationNeeded
python-client
NoReleaseNotesNeeded
Contributor
No docs changes detected for 1e536ca |
cpwright
reviewed
Jul 23, 2026
| try: | ||
| on = to_sequence(on) | ||
| joins = to_sequence(joins) | ||
| on = ",".join(to_sequence(on)) |
Contributor
There was a problem hiding this comment.
I think we should prefer to use sequence methods instead of string methods.
Contributor
Author
There was a problem hiding this comment.
In principle yes. But the string arguments work well and the code is cleaner and simpler since we don't need to create java JoinMatch objects.
| from the left table and rows from the right table, all matching combinations will be included. If no columns | ||
| to match (on) are specified, every combination of left and right table rows is included. | ||
|
|
||
| To efficiently produce updates, the bits that represent a key for a given row are split into two. Unless |
Contributor
There was a problem hiding this comment.
This might be too much credit for "10 bits is carefully chosen." @lbooker42 will need to update this comment when doing https://deephaven.atlassian.net/browse/DH-22612
jmao-denver
changed the title
Co-authored-by: Charles P. Wright <cpwright@gmail.com>
niloc132
reviewed
Jul 23, 2026
jmao-denver
marked this pull request as ready for review
July 23, 2026 19:42
cpwright
reviewed
Jul 24, 2026
cpwright
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.