Repository navigation
Repair wp/6.6 branch Actions: Fix performance-test infra crash and DataViews keyboard-nav flakiness - #377
Conversation
…2331) Co-authored-by: WunderBart <bartkalisz@git.wordpress.org> Co-authored-by: kevin940726 <kevin940726@git.wordpress.org> Co-authored-by: swissspidy <swissspidy@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: GraemeF <graemef@git.wordpress.org>
…sting DataViews keyboard nav. Ported from WordPress/gutenberg@234d95b94 (WordPress#82117), extracting only these two stabilization waits from a much larger commit that otherwise adds unrelated extensible-site-editor-v2 support not applicable to this branch. The iframe wait in particular directly targets the observed failure: the list layout mounts a preview iframe (editor-canvas) for the selected item, and its load can steal focus/rendering mid-test if not waited for.
c24bd1d to
3b32076
Compare
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
The relevant fixes (excluding the fork-only "Temporarily remove performance restriction." verification commit) were added directly to WordPress#82983 rather than as a separate PR, since they're closely related to that PR's existing site-editor-stabilization work. |
What?
Ports two upstream trunk fixes onto this branch, on top of the WordPress 6.6 performance-test version pin:
8d15c5f8b204from WordPress/gutenberg#62331 ("E2E Utils: Add retry mechanism to the REST API discovery"). WrapsRequestUtils' REST-API-discovery call in a poll/retry loop instead of a single attempt, and makes the verbose Playwrightlistreporter unconditional instead of CI-only.20e2230bd0b8from WordPress/gutenberg#78054 ("Fix flaky e2e test for Pages dataview keyboard navigation"). Adds a wait for the "Add filter" button and the grid to finish loading indataviews-list-layout-keyboard.spec.js's sharedbeforeEach, before any test sends keyboard input.Why?
Both were found investigating two CI failures on WordPress/gutenberg#82983 (Performance Tests + End-to-End Tests):
wp-env's port opens before its REST API is actually routable, so REST discovery could fail almost immediately after startup — and CI's Playwright config suppressed the verbose reporter, so any real error was silently swallowed. Trunk's fix (E2E Utils: Add retry mechanism to the REST API discovery WordPress/gutenberg#62331) addresses both halves directly.dataviews-list-layout-keyboard.spec.jsfailed withTimeoutErrors on several keyboard-navigation tests. Root cause: the Pages DataViews list finishes loading asynchronously after a REST fetch, and the tests could start sending Tab/arrow-key input before that finished — tracked upstream in WordPress/gutenberg#69851 and multiple[Flaky Test]issues dating to June 2024, ultimately fixed by Fix flaky e2e test for Pages dataview keyboard navigation WordPress/gutenberg#78054.Both fixes are ported from trunk essentially unmodified (verified to apply cleanly, files/context match this branch's copy), closing out both failure classes at the root rather than working around them in this branch's own code.
Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.