fix: Update the validator criteria to allow wifi config is empty when DHCP is false#799
Open
choonkeat1986 wants to merge 1 commit intomainfrom
Open
fix: Update the validator criteria to allow wifi config is empty when DHCP is false#799choonkeat1986 wants to merge 1 commit intomainfrom
choonkeat1986 wants to merge 1 commit intomainfrom
Conversation
cbe777a to
5fbc08f
Compare
There was a problem hiding this comment.
Pull request overview
Updates profile validation to allow empty wifiConfigs when dhcpEnabled is false, preventing erroneous validation failures when saving static wired profiles.
Changes:
- Replaced
excluded_ifvalidation onWiFiConfigswith a customwifidhcpvalidator. - Registered the new validator in profile routes and added parallelized validation-focused HTTP tests.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| internal/entity/dto/v1/profile.go | Adds ValidateWiFiDHCP and switches WiFiConfigs to use the new wifidhcp binding tag. |
| internal/controller/httpapi/v1/profiles.go | Registers the new wifidhcp validator with Gin’s validator engine. |
| internal/controller/httpapi/v1/profiles_test.go | Adds validation tests and introduces a shared custom validator with locking to support parallel tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
3b42838 to
05be8a9
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #799 +/- ##
==========================================
+ Coverage 39.63% 39.66% +0.02%
==========================================
Files 113 113
Lines 10754 10761 +7
==========================================
+ Hits 4262 4268 +6
- Misses 6093 6094 +1
Partials 399 399 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
05be8a9 to
1951c2f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the issue
When create a profile with a network configuration for wired connection as static. There will be error promp when try to save the profile. The error promp as such "Invalid input: Key: 'Profile.WiFiConfigs' Error:Field validation for 'WiFiConfigs' failed on the 'excluded_if' tag"
What are you changing?
Update the profile validator to allow the wificonfig is empty when DHCP is false.
Tested: