Conversation
and should use configured log level
There was a problem hiding this comment.
Pull request overview
Refactors application startup to use a single shared pkg/logger instance by passing it through main → app.Run and into dependent components (e.g., HTTP server, OpenAPI generation).
Changes:
- Change
internal/app.Runto accept alogger.Interfacerather than creating its own logger. - Thread the logger through
cmd/app/main.go(including OpenAPI generation path) and update related tests/mocks. - Adjust HTTP server TLS test to provide a logger via the
httpserver.Logger(...)option.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/httpserver/server_tls_test.go | Passes an explicit logger option when exercising self-signed TLS path. |
| pkg/httpserver/server.go | Removes default field initialization from New() (notably the default logger). |
| internal/app/app_test.go | Updates test to call app.Run with an explicit logger instance. |
| internal/app/app.go | Updates Run signature to accept a logger and uses it throughout setup. |
| cmd/app/main_test.go | Updates mocks/signatures for runAppFunc and OpenAPI generation calls. |
| cmd/app/main.go | Creates one logger in main, passes it into app run and OpenAPI generation logic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #802 +/- ##
==========================================
- Coverage 39.70% 39.70% -0.01%
==========================================
Files 112 112
Lines 10673 10670 -3
==========================================
- Hits 4238 4236 -2
+ Misses 6052 6051 -1
Partials 383 383 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.