assists: xlnx_overlay_pl_dt: Move amba_pl to amba rename after overlay tree construction#764
Merged
Merged
Conversation
…y tree construction The amba_pl bus is part of the system-device-tree and can be referred via overlay DT as well. Currently, lopper renames amba_pl to amba early in the flow (inside prepare_amba_node and build_overlay_tree), before the overlay tree is fully built. This causes the generated overlay to contain inconsistent bus references, leading to errors at runtime when loading the overlay on the target. Fix this by moving the amba_pl to amba rename to happen after build_overlay_tree() completes, so all references to amba_pl remain valid during overlay tree construction. Signed-off-by: Onkar Harsh <onkar.harsh@amd.com> Signed-off-by: Aravind Thokala <aravind.thokala@amd.com>
arthokal
force-pushed
the
defer-amba-rename
branch
from
8e639e6 to
9e3ffde
Compare
Contributor
Author
|
@onkarharsh , @kedareswararao |
arthokal
changed the title
Contributor
|
Looks good to me, it is co-authored. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
When loading the generated overlay DT on the target, the kernel reports:
OF: resolver: node label 'amba_pl' not found in live devicetree symbols tableRoot Cause:
This happens because lopper renames
amba_pltoambaearly in the flow, before the overlay tree is fully built. The generated overlay then contains inconsistent references that the kernel's OF resolver cannot resolve.Fix:
Move the
amba_pltoambarename to happen afterbuild_overlay_tree()completes, so all references toamba_plremain valid during overlay tree construction.Example Lopper command invocation:
LOPPER_DTC_FLAGS="-b 0 -@" ./lopper.py -O outdir -f --enhanced -i /proj/ssw_xhd/drivers/onkarh/to_aravind/updated_zocl.dtsi /proj/ssw_xhd/drivers/onkarh/to_aravind/apu_linux-chosen.dts system-top-no-pl.dts -- xlnx_overlay_pl_dt psv_cortexa72_0 full --firmware-name=gmio_async_xrt.pdi