Skip to content

Add namespace to vector, make metrics public#94

Merged
blind-oracle merged 3 commits into
mainfrom
igor/vector-namespace
Jun 1, 2026
Merged

Add namespace to vector, make metrics public#94
blind-oracle merged 3 commits into
mainfrom
igor/vector-namespace

Conversation

@blind-oracle

Copy link
Copy Markdown
Contributor

Add a namespace label to Vector metrics, export Metrics struct as public & allow creation of Vector client with pre-built metrics.

This is needed to run several instances of Vector client inside one process.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds per-instance metric separation for the Vector client by introducing a namespace label on all Vector metrics, and exposes a public Metrics type so multiple Vector clients can share a single registered metric set within one process.

Changes:

  • Converted Vector metrics from single metric types to *Vec metrics, adding a namespace label (and ok for flushes).
  • Updated Vector::new to accept a namespace and added Vector::new_with_metrics to allow injecting pre-built/shared metrics.
  • Updated call sites in the module tests to pass a namespace and read labeled metrics.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread ic-bn-lib/src/vector/client.rs
Comment thread ic-bn-lib/src/vector/client.rs
Comment thread ic-bn-lib/src/vector/client.rs
@blind-oracle blind-oracle merged commit ee341ce into main Jun 1, 2026
6 checks passed
@blind-oracle blind-oracle deleted the igor/vector-namespace branch June 1, 2026 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants