Add namespace to vector, make metrics public#94
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds per-instance metric separation for the Vector client by introducing a namespace label on all Vector metrics, and exposes a public Metrics type so multiple Vector clients can share a single registered metric set within one process.
Changes:
- Converted Vector metrics from single metric types to
*Vecmetrics, adding anamespacelabel (andokfor flushes). - Updated
Vector::newto accept anamespaceand addedVector::new_with_metricsto allow injecting pre-built/shared metrics. - Updated call sites in the module tests to pass a namespace and read labeled metrics.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
frankdavid
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
namespacelabel to Vector metrics, exportMetricsstruct as public & allow creation of Vector client with pre-built metrics.This is needed to run several instances of Vector client inside one process.