feat(nns): Support SelfDescribingValue::Bool #8366
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
This pull request changes code owned by the Governance team. Therefore, make sure that
you have considered the following (for Governance-owned code):
-
Update
unreleased_changelog.md(if there are behavior changes, even if they are
non-breaking). -
Are there BREAKING changes?
-
Is a data migration needed?
-
Security review?
How to Satisfy This Automatic Review
-
Go to the bottom of the pull request page.
-
Look for where it says this bot is requesting changes.
-
Click the three dots to the right.
-
Select "Dismiss review".
-
In the text entry box, respond to each of the numbered items in the previous
section, declare one of the following:
-
Done.
-
$REASON_WHY_NO_NEED. E.g. for
unreleased_changelog.md, "No
canister behavior changes.", or for item 2, "Existing APIs
behave as before.".
Brief Guide to "Externally Visible" Changes
"Externally visible behavior change" is very often due to some NEW canister API.
Changes to EXISTING APIs are more likely to be "breaking".
If these changes are breaking, make sure that clients know how to migrate, how to
maintain their continuity of operations.
If your changes are behind a feature flag, then, do NOT add entrie(s) to
unreleased_changelog.md in this PR! But rather, add entrie(s) later, in the PR
that enables these changes in production.
Reference(s)
For a more comprehensive checklist, see here.
GOVERNANCE_CHECKLIST_REMINDER_DEDUP
jasonz-dfinity
force-pushed
the
jason/misc-self-describing-bool
branch
from
73558ad to
4eec373
Compare
jasonz-dfinity
force-pushed
the
jason/misc-self-describing-bool
branch
from
4eec373 to
abe722f
Compare
jasonz-dfinity
dismissed
github-actions[bot]’s stale review
N/A - behind feature flag
…_value (#8437) Recent changes #8205 and #8366 added support for SelfDescribingValue::[Bool|Null], while `decode_candid_args_to_self_describing_value` was still using `Nat` for booleans and empty arrays for nulls. This PR make `decode_candid_args_to_self_describing_value` consistent with the rest of the action-based proposals.
2 participants
Use a new variant
Boolrather thanNat(1)/Nat(0). This is more intuitive and more readable thanNat.