DO NOT MERGE Test subnet rental canister with one-time Swiss subnet fix. #8397
+158
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-wong-dfinity-org
force-pushed
the
test-upgrading-subnet-rental-canister-with-one-time-swiss-subnet-fix-daniel-wong
branch
from
6c131ce to
fe23501
Compare
daniel-wong-dfinity-org
force-pushed
the
test-upgrading-subnet-rental-canister-with-one-time-swiss-subnet-fix-daniel-wong
branch
from
fe23501 to
f22392b
Compare
…g the Subnet Rental canister.
daniel-wong-dfinity-org
force-pushed
the
test-upgrading-subnet-rental-canister-with-one-time-swiss-subnet-fix-daniel-wong
branch
from
f0528ae to
8f5a72c
Compare
mraszyk
reviewed
Jan 16, 2026
| nns_canister_upgrade.modify_wasm_but_preserve_behavior(); | ||
| } | ||
|
|
||
| let rental_agreements_after_first_upgrade = list_rental_agreements(&state_machine); |
Contributor
There was a problem hiding this comment.
Let's maybe do:
for _ in 0..300 {
state_machine.advance_time(Duration::from_secs(1));
state_machine.tick();
}
to give the timers enough opportunity to execute. Same after the second round of upgrades.
Contributor
Author
There was a problem hiding this comment.
Done. I added to the end of perform_sequence_of_upgrades.
mraszyk
added a commit
to dfinity/subnet-rental-canister
that referenced
this pull request
Jan 16, 2026
The [proposal] to create the Swiss subnet partially succeeded. The reason it did not fully succeed is that the Subnet Rental canister (SRC) was running old code (we tested against version 0.3.0 of the SRC, dated July 30, but that was never deployed to production). In particular, the Governance canister tried to call the `execute_create_rental_agreement` method on the SRC, but that did not exist. [proposal]: https://dashboard.internetcomputer.org/proposal/139961 What this does is perform the same call that Governance attempted (to `execute_create_rental_agreement`), but during post-upgrade of the SRC. That is the [last step] in the process of creating the Swiss subnet. [last step]: https://sourcegraph.com/github.com/dfinity/ic@48beb3753edc4fff056025764946357b7ed03c62/-/blob/rs/nns/governance/src/proposals/fulfill_subnet_rental_request.rs?L129-134 We put together a [test to make sure that this works][test] against golden state. [test]: dfinity/ic#8397 --------- Co-authored-by: Martin Raszyk <[email protected]>
daniel-wong-dfinity-org
force-pushed
the
test-upgrading-subnet-rental-canister-with-one-time-swiss-subnet-fix-daniel-wong
branch
2 times, most recently
from
8fff047 to
a3da712
Compare
daniel-wong-dfinity-org
force-pushed
the
test-upgrading-subnet-rental-canister-with-one-time-swiss-subnet-fix-daniel-wong
branch
from
a3da712 to
ce0f9b8
Compare
daniel-wong-dfinity-org
force-pushed
the
test-upgrading-subnet-rental-canister-with-one-time-swiss-subnet-fix-daniel-wong
branch
from
6c868c2 to
473514f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses golden state.
Subnet Rental Canister build used:
7C709599CC04091EFC712B72BDD254773D2EE8BA212FB9170E6F90D854A0099DHow to run:
See attachment for test output.