Skip to content

Conversation

@matthewmcneely
Copy link
Contributor

@matthewmcneely matthewmcneely commented Sep 4, 2025

Description

This PR updates pydgraph to Dgraph version v25

Checklist

  • Code compiles correctly and linting passes locally
  • For all code changes, an entry added to the CHANGELOG.md file describing and linking to
    this PR
  • Tests added for new functionality, or regression tests for bug fixes added as applicable
  • For public APIs, new features, etc., PR on
    docs repo staged and linked here

@matthewmcneely matthewmcneely changed the title Matthewmcneely/update client to v25 chore: update client to v25 api Sep 4, 2025
@matthewmcneely matthewmcneely mentioned this pull request Sep 10, 2025
4 tasks
@matthewmcneely matthewmcneely changed the title chore: update client to v25 api feat: update client to v25 api Sep 10, 2025
@shiva-istari shiva-istari force-pushed the matthewmcneely/update-client-to-v25 branch from 701daea to 607c532 Compare December 15, 2025 07:19
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ matthewmcneely
❌ Shiva


Shiva seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@shiva-istari shiva-istari marked this pull request as ready for review December 15, 2025 07:21
Copy link
Contributor Author

@matthewmcneely matthewmcneely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more general things

  • Can you add an integration test of run_dql in a namespace that's accessed by logging in with the open func using the username:password authentication in the connection string? There's new code in client.py lines 315-321 that I'm not 100% confident in
  • Can you change all the copyright headers to Istari Digital ownership, should be
 # SPDX-FileCopyrightText: © 2017-2025 Istari Digital, Inc.
 # SPDX-License-Identifier: Apache-2.0

Also there are some other places where the hypermode term should be changed. Use Istari Digital, Inc. in those places. Where emails might be required, use [email protected]

@matthewmcneely matthewmcneely merged commit e406035 into main Dec 18, 2025
10 checks passed
@matthewmcneely matthewmcneely deleted the matthewmcneely/update-client-to-v25 branch December 18, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants