-
Notifications
You must be signed in to change notification settings - Fork 90
feat: update client to v25 api #277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Future proof docker network changes
701daea to
607c532
Compare
|
Shiva seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
matthewmcneely
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more general things
- Can you add an integration test of
run_dqlin a namespace that's accessed by logging in with the open func using theusername:passwordauthentication in the connection string? There's new code in client.py lines 315-321 that I'm not 100% confident in - Can you change all the copyright headers to Istari Digital ownership, should be
# SPDX-FileCopyrightText: © 2017-2025 Istari Digital, Inc.
# SPDX-License-Identifier: Apache-2.0
Also there are some other places where the hypermode term should be changed. Use Istari Digital, Inc. in those places. Where emails might be required, use [email protected]
Description
This PR updates pydgraph to Dgraph version v25
Checklist
CHANGELOG.mdfile describing and linking tothis PR
docs repo staged and linked here