Repository navigation
Settings > Update never shows an empty status line - #48
Merged
Merged
Conversation
…check it says so, and opening the tab runs the launch check at once The updater's idle state had no message, so for the 5 seconds before the launch check the status line was blank. Idle now reads "Updates haven't been checked yet." The status gains pending, true while the launch check waits: Settings > Update on screen then runs it at once, and any check run sooner takes the timer's place, so a launch never checks twice.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the 5 seconds before the launch check, the updater is idle, and the Update tab had no message for idle: the status line was blank.
pending, true while the launch check waits. Settings > Update on screen then runs the check at once (the existingupdate:check, no new channel).buildSettings()tells its caller each tab selected (not the first, while it's still being built).pending.Tests: a unit test for the timer skipping after a check, an e2e test for the tab running the pending check once, and the idle copy in the status-line test. 253 unit and 109 e2e pass locally; the update-server specs run in CI's packaged pass.