Repository navigation
The installer's right-click box fits on one line - #50
Merged
Merged
Conversation
…he right-click menu', and config() refuses a label over 48 characters DFC's label wrapped the old line, and the one-line checkbox clipped both lines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DFC 2.0.0-beta.6's installer clipped its right-click box top and bottom: 'Add "Convert with Diamond File Converter" to the menu when you right-click files and folders' wrapped to two lines inside a checkbox one line high.
config()refuses acontextMenu.labelover 48 characters, so it stays one line.Checked by building the demo installer with DFC's label and capturing the page: one line, nothing clipped. Unit tests 253/253.