Skip to content

Enabling translation for nested schemas#53

Open
iancarv wants to merge 1 commit into
diegohaz:masterfrom
iancarv:master
Open

Enabling translation for nested schemas#53
iancarv wants to merge 1 commit into
diegohaz:masterfrom
iancarv:master

Conversation

@iancarv

@iancarv iancarv commented Apr 23, 2019

Copy link
Copy Markdown

When using translation for nested schemas, the package ignores the new parse function for deep level schemas. This pull request fixes the issue assuring that deeper level schemas are correctly "translated".

@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #53 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #53   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          21     21           
  Lines         420    418    -2     
  Branches      117    117           
=====================================
- Hits          420    418    -2
Impacted Files Coverage Δ
packages/schm/src/mapValues.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61f86fe...e95d9cd. Read the comment docs.

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@61f86fe). Learn more about missing BASE report.
⚠️ Report is 9 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             master       #53   +/-   ##
==========================================
  Coverage          ?   100.00%           
==========================================
  Files             ?        21           
  Lines             ?       418           
  Branches          ?       117           
==========================================
  Hits              ?       418           
  Misses            ?         0           
  Partials          ?         0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants