Skip to content

Catch out-of-memory exceptions during propositional reduction #8765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tautschnig wants to merge 1 commit into
base: develop
Choose a base branch
from
+56 −32
Open

Catch out-of-memory exceptions during propositional reduction #8765

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions src/goto-checker/bmc_util.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,11 +347,23 @@ std::chrono::duration<double> prepare_property_decider(
<< property_decider.get_decision_procedure().decision_procedure_text()
<< messaget::eom;

convert_symex_target_equation(
equation, property_decider.get_decision_procedure(), ui_message_handler);
property_decider.update_properties_goals_from_symex_target_equation(
properties);
property_decider.convert_goals();
try
{
convert_symex_target_equation(
equation, property_decider.get_decision_procedure(), ui_message_handler);
property_decider.update_properties_goals_from_symex_target_equation(
properties);
property_decider.convert_goals();
}
catch(const std::bad_alloc &)
{
log.error() << "Solver ran out of memory during propositional reduction."
<< messaget::eom;
log.error()
<< "Try reducing the problem size or increasing available memory."
<< messaget::eom;
throw;
}

auto solver_stop = std::chrono::steady_clock::now();
return std::chrono::duration<double>(solver_stop - solver_start);
Expand Down
66 changes: 39 additions & 27 deletions src/solvers/prop/prop_conv_solver.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -443,44 +443,56 @@ void prop_conv_solvert::finish_eager_conversion()
decision_proceduret::resultt
prop_conv_solvert::dec_solve(const exprt &assumption)
{
// post-processing isn't incremental yet
if(!post_processing_done)
try
{
const auto post_process_start = std::chrono::steady_clock::now();
// post-processing isn't incremental yet
if(!post_processing_done)
{
const auto post_process_start = std::chrono::steady_clock::now();

log.progress() << "Post-processing" << messaget::eom;
finish_eager_conversion();
post_processing_done = true;
log.progress() << "Post-processing" << messaget::eom;
finish_eager_conversion();
post_processing_done = true;

const auto post_process_stop = std::chrono::steady_clock::now();
std::chrono::duration<double> post_process_runtime =
std::chrono::duration<double>(post_process_stop - post_process_start);
log.statistics() << "Runtime Post-process: " << post_process_runtime.count()
<< "s" << messaget::eom;
}
const auto post_process_stop = std::chrono::steady_clock::now();
std::chrono::duration<double> post_process_runtime =
std::chrono::duration<double>(post_process_stop - post_process_start);
log.statistics() << "Runtime Post-process: "
<< post_process_runtime.count() << "s" << messaget::eom;
}

log.progress() << "Solving with " << prop.solver_text() << messaget::eom;
log.progress() << "Solving with " << prop.solver_text() << messaget::eom;

if(assumption.is_nil())
push();
else
push({assumption});
if(assumption.is_nil())
push();
else
push({assumption});

auto prop_result = prop.prop_solve(assumption_stack);
auto prop_result = prop.prop_solve(assumption_stack);

pop();
pop();

switch(prop_result)
switch(prop_result)
{
case propt::resultt::P_SATISFIABLE:
return resultt::D_SATISFIABLE;
case propt::resultt::P_UNSATISFIABLE:
return resultt::D_UNSATISFIABLE;
case propt::resultt::P_ERROR:
return resultt::D_ERROR;
}

UNREACHABLE;
}
catch(const std::bad_alloc &)
{
case propt::resultt::P_SATISFIABLE:
return resultt::D_SATISFIABLE;
case propt::resultt::P_UNSATISFIABLE:
return resultt::D_UNSATISFIABLE;
case propt::resultt::P_ERROR:
log.error() << "Solver ran out of memory during propositional reduction."
<< messaget::eom;
log.error()
<< "Try reducing the problem size or increasing available memory."
<< messaget::eom;
return resultt::D_ERROR;
}

UNREACHABLE;
}

exprt prop_conv_solvert::get(const exprt &expr) const
Expand Down
Loading