Skip to content

Remove undefined-function-is-assume-false from goto-instrument #8783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tautschnig wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Remove undefined-function-is-assume-false from goto-instrument #8783

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions doc/man/goto-instrument.1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,9 +414,6 @@ prepends a call to \fIcallee\fR in the body of \fIcaller\fR
instruments checks to assert that all call
sequences match \fIseq\fR
.TP
\fB\-\-undefined\-function\-is\-assume\-false\fR
convert each call to an undefined function to assume(false)
.TP
\fB\-\-insert\-final\-assert\-false\fR \fIfunction\fR
generate assert(false) at end of \fIfunction\fR
.TP
Expand Down
8 changes: 0 additions & 8 deletions src/goto-instrument/goto_instrument_parse_options.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -911,12 +911,6 @@ int goto_instrument_parse_optionst::doit()
remove_unused_functions(goto_model.goto_functions, ui_message_handler);
}

if(cmdline.isset("undefined-function-is-assume-false"))
{
do_indirect_call_and_rtti_removal();
undefined_function_abort_path(goto_model);
}

// write new binary?
if(cmdline.args.size()==2)
{
Expand Down Expand Up @@ -1959,8 +1953,6 @@ void goto_instrument_parse_optionst::help()
" the body of {ucaller}\n"
" {y--check-call-sequence} {useq} \t instruments checks to assert that all"
" call sequences match {useq}\n"
" {y--undefined-function-is-assume-false} \t convert each call to an"
" undefined function to assume(false)\n"
HELP_INSERT_FINAL_ASSERT_FALSE
HELP_REPLACE_FUNCTION_BODY
HELP_RESTRICT_FUNCTION_POINTER
Expand Down
1 change: 0 additions & 1 deletion src/goto-instrument/goto_instrument_parse_options.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,6 @@ Author: Daniel Kroening, [email protected]
"(" FLAG_ENFORCE_CONTRACT "):" \
OPT_ENFORCE_CONTRACT_REC \
"(show-threaded)(list-calls-args)" \
"(undefined-function-is-assume-false)" \
"(remove-function-body):" \
"(remove-function-body-regex):" \
OPT_AGGRESSIVE_SLICER \
Expand Down
34 changes: 0 additions & 34 deletions src/goto-instrument/undefined_functions.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,37 +31,3 @@ void list_undefined_functions(
os << gf_entry.first << '\n';
}
}

void undefined_function_abort_path(goto_modelt &goto_model)
{
for(auto &gf_entry : goto_model.goto_functions.function_map)
{
for(auto &ins : gf_entry.second.body.instructions)
{
if(!ins.is_function_call())
continue;

const auto &function = ins.call_function();

if(function.id() != ID_symbol)
continue;

const irep_idt &function_identifier =
to_symbol_expr(function).get_identifier();

goto_functionst::function_mapt::const_iterator entry =
goto_model.goto_functions.function_map.find(function_identifier);
DATA_INVARIANT(
entry!=goto_model.goto_functions.function_map.end(),
"called function must be in function_map");

if(entry->second.body_available())
continue;

source_locationt annotated_location = ins.source_location();
annotated_location.set_comment(
"'" + id2string(function_identifier) + "' is undefined");
ins = goto_programt::make_assumption(false_exprt(), annotated_location);
}
}
}
2 changes: 0 additions & 2 deletions src/goto-instrument/undefined_functions.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,4 @@ void list_undefined_functions(
const goto_modelt &,
std::ostream &);

void undefined_function_abort_path(goto_modelt &);

#endif
Loading