Skip to content

Conversation

@tautschnig
Copy link
Collaborator

Validate output file presence before expensive analysis operations to prevent wasted computation when command is malformed.

Fixes: #2593

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Validate output file presence before expensive analysis operations to
prevent wasted computation when command is malformed.

Fixes: diffblue#2593
@tautschnig tautschnig force-pushed the fix-2593-goto-instrument-args branch from 6166876 to a8315e7 Compare December 2, 2025 11:39
@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

❌ Patch coverage is 82.35294% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.00%. Comparing base (1505c36) to head (a8315e7).

Files with missing lines Patch % Lines
.../goto-instrument/goto_instrument_parse_options.cpp 82.35% 9 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8784   +/-   ##
========================================
  Coverage    80.00%   80.00%           
========================================
  Files         1700     1700           
  Lines       188254   188305   +51     
  Branches        73       73           
========================================
+ Hits        150615   150657   +42     
- Misses       37639    37648    +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tautschnig tautschnig marked this pull request as ready for review December 2, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

goto-instrument behaviour when not given an output file name

2 participants