chore: retire phantom capability surfaces and dead settings screens - #3110
chore: retire phantom capability surfaces and dead settings screens#3110benjaminshafii wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
Validation: real app, isolated Linux sandbox, matched A/BAll nine branches of this series were merged into one integration branch (
Step 4 fails identically on clean Validated frames: A real regression this caught, in this seriesBooting the real app initially failed with:
Static verification on the merged resultHonest gaps
|
Correction to my validation note aboveIn the "Honest gaps" section I wrote that local macOS That diagnosis was wrong. I tested it properly afterwards and disproved it:
So dev Electron currently opens no window on this macOS host regardless of profile, keychain, or worktree. It is pre-existing, unrelated to this series, and I have not root-caused it. The same commits do open a window in a clean Linux sandbox, which is where the validation above was run — so the core-flow evidence in this comment stands unchanged. The shared-profile collision is nonetheless real (two worktrees genuinely cannot both hold the lock, and the loser lingers with an open CDP port and no log line). That is fixed separately in #3124, which adds Flagging it because the original wording would have sent a reviewer chasing the wrong cause. |
Problem
The app advertises capabilities and screens that do not exist. During an enterprise walkthrough this cost real credibility — we were asked about a feature the agent still claims to have, and pointed at settings screens that silently redirect.
Verified phantoms:
help.capabilitiesadvertises "Automations — Schedule recurring tasks and background agents" (control-provider.tsx:814). The scheduler was deleted in53e0e1d11; there is no scheduler, cron, job table, job route, or automations UI anywhere in the tree. We were advertising it to the agent.skills-view.tsx(508 lines: view/edit/create/import/reveal) is imported by nothing — superseded by the unified inventory in820d00ad3.cloud-marketplaces-view.tsx(989 lines) is referenced only by its own test and one stale doc line.SettingsTabdeclaresskillsandcloud-marketplaceswith labels, icons and descriptions, but neither is in any nav array and neither has a rendercase— the type was lying.background-agents-screen.tsxpromised scheduling with "Coming soon" while containing none, reachable by URL only.Change
Delete the dead code, remove the phantom capability, and make the copy honest.
-2026 / +5lines.Orphaned store methods removed after per-symbol proof of zero callers:
saveSkill,importLocalSkill,installSkillCreator,revealSkillsFolder(+ theskill-creator.mdtemplate only that path consumed, + their i18n keys across all 10 locales).readSkillanduninstallSkillwere kept —mcp-view.tsxuses them.Deliberately kept: the legacy
/settings/skillsand/settings/cloud-marketplacesredirects (real deep-link back-compat), and the background-agents page itself (it lists real workers and mints connect tokens) — only its misleading "Coming soon" framing was removed.Also corrected two docs click-paths that pointed at removed sub-tabs (
get-started.mdx,team-templates.mdx), and the agent-facing skills path inopenwork-capabilities-knowledge.ts.Verification
Final
rgsweep for every deleted symbol/file returns empty. No behavior changes beyond removing false advertising.