fix(desktop): handle Windows verbatim path prefix to fix app startup crash#3134
Draft
Pallavikumarimdb wants to merge 1 commit into
Draft
fix(desktop): handle Windows verbatim path prefix to fix app startup crash#3134Pallavikumarimdb wants to merge 1 commit into
Pallavikumarimdb wants to merge 1 commit into
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
@Pallavikumarimdb is attempting to deploy a commit to the Different AI Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an app startup crash on Windows.
The crash happens because Electron's
app.getPath("userData")orapp.getPath("appData")sometimes returns native Windows verbatim (extended-length) paths starting with\\?\(e.g.,\\?\C:\Users\username\AppData\Local\...).Node.js standard path utilities (
path.resolve,path.dirname, etc.) do not treat this prefix specially. When passed directly to path operations, the prefix was mangled into a path like\?, which subsequently failed withENOENTduringmkdircalls when creating directories like the Start Menu shortcut directory or the server configurations.Changes
stripWindowsVerbatimPrefixhelper inmain.mjsandworkspace-store.mjsto strip\\?\,\\?\UNC\, and device prefixes from Windows paths before they are passed to path or filesystem operations.windowsProgramsPath(): Usedprocess.env.USERPROFILEas the primary source of the user's home folder on Windows (which always returns a clean path) rather than splitting a potentially verbatimuserDatapath string.normalizeLocalWorkspacePath(): Normalized and stripped verbatim prefixes before callingpath.resolveso that stored workspace paths do not resolve to incorrect/mangled locations.Why
Issue
Scope
Out of scope
Testing
Ran
...Result
CI status
Manual verification
Evidence
N/A (docs-only)Risk
Rollback