revert(app): revert signed-in Den startup gate before Run Task (#3300) - #3371
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
OmarMcAdam
approved these changes
Jul 30, 2026
src-opn
approved these changes
Jul 31, 2026
benjaminshafii
enabled auto-merge (squash)
July 31, 2026 10:44
…)" This reverts commit 64786c4.
benjaminshafii
force-pushed
the
revert/den-startup-run-task-gate
branch
from
July 31, 2026 10:47
b1a1dec to
5e61a06
Compare
Member
Author
|
The red Fixed in #3378 (bump to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
64786c44d, "fix(app): wait for signed-in Den startup before Run Task"), restoring the previous Run Task / composer submit behavior.cloud-mcp-app-readiness.tsis deleted andsession-route.tsx,session-surface.tsx,composer.tsx,new-task-composer.tsx,session-empty-hero.tsx, anduse-session-mcp-maintenance.tsgo back to consumingcloudMcpSubmissionStatedirectly, with noonRetryCloudConnectionplumbing.apps/app/src/react-app/shell/session-route.tsxwas resolved by hand: a commit landed after fix(app): wait for signed-in Den startup before Run Task #3300 renamed the connect handler, so the neweronOpenConnect: () => handleOpenExtensions()is kept (instead of the oldernavigate("/settings/extensions")) andhandleOpenExtensionsstays in the memo dependency list since it is still used byonOpenSettingsSection.Evidence
Build verification
pnpm --filter @openwork/app build— passed (vite build succeeded, only the pre-existing chunk-size warnings).pnpm tsc --noEmitinapps/app— passed, clean. This is the check that matters most here, since it confirms the hand-resolved conflict left no dangling references to the reverted symbols (effectiveCloudMcpSubmissionState,cloudMcpAppSubmission*,IDLE_CLOUD_MCP_SUBMISSION_GATE_STATE).Test verification
pnpm testinapps/app(bun test --isolate tests/) crashes the runner with exit 133 ontests/opencode-stream-timeout.test.ts. This is pre-existing, not caused by this revert: the identical crash reproduces on the base commit2c558bcffwith the same exit code and same file.bun test tests/opencode-stream-timeout.test.tson its own passes 4/4, so the crash only appears under--isolatein the full-suite run.UI verification
No UI verification was performed — I did not boot the app or drive the flow. This is a straight revert of a previously reviewed commit, so the reviewer should confirm the Run Task behavior matches what it was before #3300 landed.
API verification
No API changes.
Test instructions
pnpm --filter @openwork/app devhandleOpenExtensionsimplementation, not reverted).Made with Cursor