Permit git cat-file in pre-commit shim - #33
Merged
Conversation
Contributor
Author
|
While working on this I noticed a few more subcommands that are always read-only and could join the list:
I only need cat-file myself so I kept the PR to that, but happy to add some or all of these here if you'd rather batch them. |
Owner
|
Thanks! 💖 Will cut a new release shortly. Opened #34 to track the others. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran into this with a pre-commit hook that compares the HEAD and staged versions of the files being committed. It reads the blobs with
git cat-file --batch, which the shim currently rejects (git is not allowed in parallel hooks (git cat-file --batch)).cat-file is read-only, same family as the commands allowed in #21 and #24.